Commit d370c90d authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: ti_usb_3410_5052: fix TIOCSSERIAL permission check 



Changing the port closing-wait parameter is a privileged operation so
make sure to return -EPERM if a regular user tries to change it.

Cc: stable@vger.kernel.org
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 4c47dc2a

drivers/usb/serial/ti_usb_3410_5052.c

+7 −2
Original line number Diff line number Diff line
@@ -1418,14 +1418,19 @@ static int ti_set_serial_info(struct tty_struct *tty, 
	struct serial_struct *ss)

{

	struct usb_serial_port *port = tty->driver_data;

	struct ti_port *tport = usb_get_serial_port_data(port);

	struct tty_port *tport = &port->port;

	unsigned cwait;



	cwait = ss->closing_wait;

	if (cwait != ASYNC_CLOSING_WAIT_NONE)

		cwait = msecs_to_jiffies(10 * ss->closing_wait);



	tport->tp_port->port.closing_wait = cwait;

	if (!capable(CAP_SYS_ADMIN)) {

		if (cwait != tport->closing_wait)

			return -EPERM;

	}



	tport->closing_wait = cwait;



	return 0;

}