Commit d2fcc9c2 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

media: imx: imx7_mipi_csis: Fix logging of only error event counters 



The mipi_csis_events array ends with 6 non-error events, not 4. Update
mipi_csis_log_counters() accordingly. While at it, log event counters in
forward order, as there's no reason to log them backward.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Tested-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent f4815b39

drivers/staging/media/imx/imx7-mipi-csis.c

+4 −2
Original line number Diff line number Diff line
@@ -666,13 +666,15 @@ static void mipi_csis_clear_counters(struct csi_state *state) 


static void mipi_csis_log_counters(struct csi_state *state, bool non_errors)

{

	int i = non_errors ? MIPI_CSIS_NUM_EVENTS : MIPI_CSIS_NUM_EVENTS - 4;

	unsigned int num_events = non_errors ? MIPI_CSIS_NUM_EVENTS

				: MIPI_CSIS_NUM_EVENTS - 6;

	struct device *dev = &state->pdev->dev;

	unsigned long flags;

	unsigned int i;



	spin_lock_irqsave(&state->slock, flags);



	for (i--; i >= 0; i--) {

	for (i = 0; i < num_events; ++i) {

		if (state->events[i].counter > 0 || state->debug)

			dev_info(dev, "%s events: %d\n", state->events[i].name,

				 state->events[i].counter);