Commit d268f4bd authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: pcf8563: remove RTC_VL_CLR handling 

Remove RTC_VL_CLR handling because it is a disservice to userspace as it
removes the important information that the RTC data is invalid. This may
lead userspace to set an invalid system time later on.

Link: https://lore.kernel.org/r/20191214220259.621996-7-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 244cf8f0

drivers/rtc/rtc-pcf8563.c

+0 −15
Original line number Diff line number Diff line
@@ -291,21 +291,6 @@ static int pcf8563_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long 
					sizeof(int)))

			return -EFAULT;

		return 0;

	case RTC_VL_CLR:

		/*

		 * Clear the VL bit in the seconds register in case

		 * the time has not been set already (which would

		 * have cleared it). This does not really matter

		 * because of the cached voltage_low value but do it

		 * anyway for consistency.

		 */

		if (pcf8563_rtc_read_time(dev, &tm))

			pcf8563_rtc_set_time(dev, &tm);



		/* Clear the cached value. */

		pcf8563->voltage_low = 0;



		return 0;

	default:

		return -ENOIOCTLCMD;

	}