Commit d18ba9f1 authored by Zekun Shen's avatar Zekun Shen Committed by Kalle Valo
Browse files

ath10k: sanitity check for ep connectivity 



Function ep_rx_complete is being called without NULL checking
in ath10k_htc_rx_completion_handler. Without such check, mal-
formed packet is able to cause jump to NULL.

ep->service_id seems a good candidate for sanity check as it is
used in usb.c.

Signed-off-by: default avatarZekun Shen <bruceshenzk@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200622022055.16028-1-bruceshenzk@gmail.com
parent dc5771df

drivers/net/wireless/ath/ath10k/htc.c

+4 −0
Original line number Diff line number Diff line
@@ -449,6 +449,10 @@ void ath10k_htc_rx_completion_handler(struct ath10k *ar, struct sk_buff *skb) 
	}



	ep = &htc->endpoint[eid];

	if (ep->service_id == ATH10K_HTC_SVC_ID_UNUSED) {

		ath10k_warn(ar, "htc rx endpoint %d is not connected\n", eid);

		goto out;

	}



	payload_len = __le16_to_cpu(hdr->len);