Commit d183b20d authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Nishanth Menon
Browse files

soc/ti: pruss: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> # qcom
Link: https://lore.kernel.org/r/20230925095532.1984344-38-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarNishanth Menon <nm@ti.com>
parent 9eb950e9

drivers/soc/ti/pruss.c

+2 −4
Original line number Diff line number Diff line
@@ -565,7 +565,7 @@ static int pruss_probe(struct platform_device *pdev) 
	return ret;

}



static int pruss_remove(struct platform_device *pdev)

static void pruss_remove(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;
@@ -573,8 +573,6 @@ static int pruss_remove(struct platform_device *pdev) 


	pm_runtime_put_sync(dev);

	pm_runtime_disable(dev);



	return 0;

}



/* instance-specific driver private data */
@@ -610,7 +608,7 @@ static struct platform_driver pruss_driver = { 
		.of_match_table = pruss_of_match,

	},

	.probe  = pruss_probe,

	.remove = pruss_remove,

	.remove_new = pruss_remove,

};

module_platform_driver(pruss_driver);