Commit d0d69280 authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/amdgpu: Fix identifier names to function definition arguments in atom.h 



Fixes the following:

WARNING: function definition argument 'struct card_info *' should also have an identifier name
WARNING: function definition argument 'uint32_t' should also have an identifier name
WARNING: function definition argument 'void *' should also have an identifier name
WARNING: function definition argument 'struct atom_context *' should also have an identifier name
WARNING: function definition argument 'int' should also have an identifier name
WARNING: function definition argument 'uint32_t *' should also have an identifier name
WARNING: Unnecessary space before function pointer name
ERROR: space prohibited after that '*' (ctx:BxW)
CHECK: Prefer kernel type 'u32' over 'uint32_t'

Cc: Guchun Chen <guchun.chen@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e4538bc7

drivers/gpu/drm/amd/amdgpu/atom.h

+13 −10
Original line number Diff line number Diff line
@@ -117,12 +117,15 @@ struct drm_device; 


struct card_info {

	struct drm_device *dev;

	void (* reg_write)(struct card_info *, uint32_t, uint32_t);   /*  filled by driver */

	uint32_t (* reg_read)(struct card_info *, uint32_t);          /*  filled by driver */

	void (* mc_write)(struct card_info *, uint32_t, uint32_t);   /*  filled by driver */

	uint32_t (* mc_read)(struct card_info *, uint32_t);          /*  filled by driver */

	void (* pll_write)(struct card_info *, uint32_t, uint32_t);   /*  filled by driver */

	uint32_t (* pll_read)(struct card_info *, uint32_t);          /*  filled by driver */

	void (*reg_write)(struct card_info *info,

			  u32 reg, uint32_t val);   /*  filled by driver */

	uint32_t (*reg_read)(struct card_info *info, uint32_t reg);          /*  filled by driver */

	void (*mc_write)(struct card_info *info,

			 u32 reg, uint32_t val);   /*  filled by driver */

	uint32_t (*mc_read)(struct card_info *info, uint32_t reg);          /*  filled by driver */

	void (*pll_write)(struct card_info *info,

			  u32 reg, uint32_t val);   /*  filled by driver */

	uint32_t (*pll_read)(struct card_info *info, uint32_t reg);          /*  filled by driver */

};



struct atom_context {
@@ -152,10 +155,10 @@ struct atom_context { 


extern int amdgpu_atom_debug;



struct atom_context *amdgpu_atom_parse(struct card_info *, void *);

int amdgpu_atom_execute_table(struct atom_context *, int, uint32_t *);

int amdgpu_atom_asic_init(struct atom_context *);

void amdgpu_atom_destroy(struct atom_context *);

struct atom_context *amdgpu_atom_parse(struct card_info *card, void *bios);

int amdgpu_atom_execute_table(struct atom_context *ctx, int index, uint32_t *params);

int amdgpu_atom_asic_init(struct atom_context *ctx);

void amdgpu_atom_destroy(struct atom_context *ctx);

bool amdgpu_atom_parse_data_header(struct atom_context *ctx, int index, uint16_t *size,

			    uint8_t *frev, uint8_t *crev, uint16_t *data_start);

bool amdgpu_atom_parse_cmd_header(struct atom_context *ctx, int index,