Commit cd7946c5 authored by Bartlomiej Zolnierkiewicz's avatar Bartlomiej Zolnierkiewicz
Browse files

video: fbdev: amifb: add FIXMEs about {put,get}_user() failures 



Since we lack the hardware (or proper emulator setup) for
testing needed changes add FIXMEs to document the issues
(so at least they are not forgotten).

Cc: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/380c0494-ed02-b2be-65b0-d385627fb894@samsung.com
parent 40bf8c3a

drivers/video/fbdev/amifb.c

+2 −0
Original line number Diff line number Diff line
@@ -1890,6 +1890,7 @@ static int ami_get_var_cursorinfo(struct fb_var_cursorinfo *var, 
				 | ((datawords >> 15) & 1));

			datawords <<= 1;

#endif

			/* FIXME: check the return value + test the change */

			put_user(color, data++);

		}

		if (bits > 0) {
@@ -1958,6 +1959,7 @@ static int ami_set_var_cursorinfo(struct fb_var_cursorinfo *var, 
		bits = 16; words = delta; datawords = 0;

		for (width = (short)var->width - 1; width >= 0; width--) {

			unsigned long tdata = 0;

			/* FIXME: check the return value + test the change */

			get_user(tdata, data);

			data++;

#ifdef __mc68000__