Commit cd76175a authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: rawmidi: Make internal functions local static 

__snd_rawmidi_transmit_peek() and __snd_rawmidi_transmit_ack() are
never called from the outside.  Let's make them local static and
unexport them.

Link: https://lore.kernel.org/r/20220617144051.18985-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f777316e

include/sound/rawmidi.h

+0 −4
Original line number Diff line number Diff line
@@ -156,10 +156,6 @@ int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream, 
int snd_rawmidi_transmit_ack(struct snd_rawmidi_substream *substream, int count);

int snd_rawmidi_transmit(struct snd_rawmidi_substream *substream,

			 unsigned char *buffer, int count);

int __snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream,

			      unsigned char *buffer, int count);

int __snd_rawmidi_transmit_ack(struct snd_rawmidi_substream *substream,

			       int count);

int snd_rawmidi_proceed(struct snd_rawmidi_substream *substream);



/* main midi functions */

sound/core/rawmidi.c

+6 −7
Original line number Diff line number Diff line
@@ -1258,7 +1258,7 @@ int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream) 
}

EXPORT_SYMBOL(snd_rawmidi_transmit_empty);



/**

/*

 * __snd_rawmidi_transmit_peek - copy data from the internal buffer

 * @substream: the rawmidi substream

 * @buffer: the buffer pointer
@@ -1266,7 +1266,7 @@ EXPORT_SYMBOL(snd_rawmidi_transmit_empty); 
 *

 * This is a variant of snd_rawmidi_transmit_peek() without spinlock.

 */

int __snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream,

static int __snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream,

				       unsigned char *buffer, int count)

{

	int result, count1;
@@ -1304,7 +1304,6 @@ int __snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream, 
      __skip:

	return result;

}

EXPORT_SYMBOL(__snd_rawmidi_transmit_peek);



/**

 * snd_rawmidi_transmit_peek - copy data from the internal buffer
@@ -1334,14 +1333,15 @@ int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream, 
}

EXPORT_SYMBOL(snd_rawmidi_transmit_peek);



/**

/*

 * __snd_rawmidi_transmit_ack - acknowledge the transmission

 * @substream: the rawmidi substream

 * @count: the transferred count

 *

 * This is a variant of __snd_rawmidi_transmit_ack() without spinlock.

 */

int __snd_rawmidi_transmit_ack(struct snd_rawmidi_substream *substream, int count)

static int __snd_rawmidi_transmit_ack(struct snd_rawmidi_substream *substream,

				      int count)

{

	struct snd_rawmidi_runtime *runtime = substream->runtime;
@@ -1361,7 +1361,6 @@ int __snd_rawmidi_transmit_ack(struct snd_rawmidi_substream *substream, int coun 
	}

	return count;

}

EXPORT_SYMBOL(__snd_rawmidi_transmit_ack);



/**

 * snd_rawmidi_transmit_ack - acknowledge the transmission