Commit cd2eebfd authored by Lee Jones's avatar Lee Jones Committed by Martin K. Petersen
Browse files

scsi: pm8001: Add descriptions for unused 'attr' function parameters 

Clean-up some whitespace issues too whilst we're here.

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/pm8001/pm8001_ctl.c:102: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_fw_version_show'
 drivers/scsi/pm8001/pm8001_ctl.c:331: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_logging_level_show'
 drivers/scsi/pm8001/pm8001_ctl.c:400: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_ib_queue_log_show'
 drivers/scsi/pm8001/pm8001_ctl.c:433: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_ob_queue_log_show'
 drivers/scsi/pm8001/pm8001_ctl.c:464: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_bios_version_show'
 drivers/scsi/pm8001/pm8001_ctl.c:623: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_gsm_log_show'

Link: https://lore.kernel.org/r/20200721164148.2617584-12-lee.jones@linaro.org


Cc: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a0cf5ce4

drivers/scsi/pm8001/pm8001_ctl.c

+8 −1
Original line number Diff line number Diff line
@@ -93,6 +93,7 @@ static DEVICE_ATTR_RO(controller_fatal_error); 
/**

 * pm8001_ctl_fw_version_show - firmware version

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.
@@ -322,6 +323,7 @@ static DEVICE_ATTR(host_sas_address, S_IRUGO, 
/**

 * pm8001_ctl_logging_level_show - logging level

 * @cdev: pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 *

 * A sysfs 'read/write' shost attribute.
@@ -335,6 +337,7 @@ static ssize_t pm8001_ctl_logging_level_show(struct device *cdev, 


	return snprintf(buf, PAGE_SIZE, "%08xh\n", pm8001_ha->logging_level);

}



static ssize_t pm8001_ctl_logging_level_store(struct device *cdev,

	struct device_attribute *attr, const char *buf, size_t count)

{
@@ -392,6 +395,7 @@ static DEVICE_ATTR(aap_log, S_IRUGO, pm8001_ctl_aap_log_show, NULL); 
/**

 * pm8001_ctl_ib_queue_log_show - Out bound Queue log

 * @cdev:pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 * A sysfs 'read-only' shost attribute.

 */
@@ -424,6 +428,7 @@ static DEVICE_ATTR(ib_log, S_IRUGO, pm8001_ctl_ib_queue_log_show, NULL); 
/**

 * pm8001_ctl_ob_queue_log_show - Out bound Queue log

 * @cdev:pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf: the buffer returned

 * A sysfs 'read-only' shost attribute.

 */
@@ -456,6 +461,7 @@ static DEVICE_ATTR(ob_log, S_IRUGO, pm8001_ctl_ob_queue_log_show, NULL); 
/**

 * pm8001_ctl_bios_version_show - Bios version Display

 * @cdev:pointer to embedded class device

 * @attr: device attribute (unused)

 * @buf:the buffer returned

 * A sysfs 'read-only' shost attribute.

 */
@@ -615,6 +621,7 @@ static DEVICE_ATTR_RW(non_fatal_count); 
/**

 ** pm8001_ctl_gsm_log_show - gsm dump collection

 ** @cdev:pointer to embedded class device

 ** @attr: device attribute (unused)

 ** @buf: the buffer returned

 ** A sysfs 'read-only' shost attribute.

 **/