Commit cc312da2 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

VMCI: No need to clear memory after a dma_alloc_coherent() call 



dma_alloc_coherent() already clear the allocated memory, there is no need
to explicitly call memset().
This saves a few cycles and a few lines of code.

Acked-by: default avatarVishnu Dasa <vdasa@vmware.com>
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/3e8c0bfaa77500e22d6c90f249da1c53dbae716e.1645734041.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b791da23

drivers/misc/vmw_vmci/vmci_guest.c

+2 −4
Original line number Diff line number Diff line
@@ -706,14 +706,12 @@ static int vmci_guest_probe_device(struct pci_dev *pdev, 
		vmci_dev->notification_bitmap = dma_alloc_coherent(

			&pdev->dev, PAGE_SIZE, &vmci_dev->notification_base,

			GFP_KERNEL);

		if (!vmci_dev->notification_bitmap) {

		if (!vmci_dev->notification_bitmap)

			dev_warn(&pdev->dev,

				 "Unable to allocate notification bitmap\n");

		} else {

			memset(vmci_dev->notification_bitmap, 0, PAGE_SIZE);

		else

			caps_in_use |= VMCI_CAPS_NOTIFICATIONS;

	}

	}



	if (mmio_base != NULL) {

		if (capabilities & VMCI_CAPS_DMA_DATAGRAM) {