Commit cb61e9db authored by Lee Jones's avatar Lee Jones Committed by Rob Herring
Browse files

of: device: Fix function name in header and provide missing descriptions 



Fixes the following W=1 kernel build warning(s):

 drivers/of/device.c:72: warning: expecting prototype for of_dma_configure(). Prototype was for of_dma_configure_id() instead
 drivers/of/device.c:263: warning: Function parameter or member 'dev' not described in 'of_device_modalias'
 drivers/of/device.c:263: warning: Function parameter or member 'str' not described in 'of_device_modalias'
 drivers/of/device.c:263: warning: Function parameter or member 'len' not described in 'of_device_modalias'
 drivers/of/device.c:280: warning: Function parameter or member 'dev' not described in 'of_device_uevent'
 drivers/of/device.c:280: warning: Function parameter or member 'env' not described in 'of_device_uevent'

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: devicetree@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210318104036.3175910-2-lee.jones@linaro.org
parent c6055550

drivers/of/device.c

+6 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ int of_device_add(struct platform_device *ofdev) 
}



/**

 * of_dma_configure - Setup DMA configuration

 * of_dma_configure_id - Setup DMA configuration

 * @dev:	Device to apply DMA configuration

 * @np:		Pointer to OF node having DMA configuration

 * @force_dma:  Whether device is to be set up by of_dma_configure() even if
@@ -258,6 +258,9 @@ EXPORT_SYMBOL_GPL(of_device_request_module); 


/**

 * of_device_modalias - Fill buffer with newline terminated modalias string

 * @dev:	Calling device

 * @str:	Modalias string

 * @len:	Size of @str

 */

ssize_t of_device_modalias(struct device *dev, char *str, ssize_t len)

{
@@ -275,6 +278,8 @@ EXPORT_SYMBOL_GPL(of_device_modalias); 


/**

 * of_device_uevent - Display OF related uevent information

 * @dev:	Device to apply DMA configuration

 * @env:	Kernel object's userspace event reference

 */

void of_device_uevent(struct device *dev, struct kobj_uevent_env *env)

{