Commit c9a1d9e7 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Greg Kroah-Hartman
Browse files

usb: core: Remove duplicated check in usb_hub_create_port_device 



Simplify the code by not calling hub_is_superspeed() twice.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/b1d77cbc-faa3-4d07-94ff-f6ffb85c6964@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1a4a2df0

drivers/usb/core/port.c

+1 −2
Original line number Diff line number Diff line
@@ -713,6 +713,7 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1) 
	set_bit(port1, hub->power_bits);

	port_dev->dev.parent = hub->intfdev;

	if (hub_is_superspeed(hdev)) {

		port_dev->is_superspeed = 1;

		port_dev->usb3_lpm_u1_permit = 1;

		port_dev->usb3_lpm_u2_permit = 1;

		port_dev->dev.groups = port_dev_usb3_group;
@@ -720,8 +721,6 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1) 
		port_dev->dev.groups = port_dev_group;

	port_dev->dev.type = &usb_port_device_type;

	port_dev->dev.driver = &usb_port_driver;

	if (hub_is_superspeed(hub->hdev))

		port_dev->is_superspeed = 1;

	dev_set_name(&port_dev->dev, "%s-port%d", dev_name(&hub->hdev->dev),

			port1);

	mutex_init(&port_dev->status_lock);