Commit c7ef5e28 authored Jul 11, 2022 by Geert Uytterhoeven Committed by Helge Deller Jul 18, 2022

video: fbdev: atari: Fix inverse handling



Currently, the "inverse" option does not do anything, as it just sets a
flag, which is further unused.

Fix this by calling fb_invert_cmaps() instead, like other drivers do.
As this only affects the console colormap, this does not affect X.
Update the documentation to match the actual behavior.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

parent 211f88e8

Documentation/m68k/kernel-options.rst

+2 −2

Original line number	Diff line number	Diff line
		@@ -367,8 +367,8 @@ activated by a "external:" sub-option.
		4.1.2) inverse
		--------------

		Invert the display. This affects both, text (consoles) and graphics
		(X) display. Usually, the background is chosen to be black. With this
		Invert the display. This affects only text consoles.
		Usually, the background is chosen to be black. With this
		option, you can make the background white.

		4.1.3) font

drivers/video/fbdev/atafb.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -236,8 +236,6 @@ static int *MV300_reg = MV300_reg_8bit;
		#endif /* ATAFB_EXT */


		static int inverse;

		/*
		* struct fb_ops {
		* * open/release and usage marking
		@@ -2971,7 +2969,7 @@ static int __init atafb_setup(char *options)
		default_par = temp;
		mode_option = this_opt;
		} else if (!strcmp(this_opt, "inverse"))
		inverse = 1;
		fb_invert_cmaps();
		else if (!strncmp(this_opt, "hwscroll_", 9)) {
		hwscroll = simple_strtoul(this_opt + 9, NULL, 10);
		if (hwscroll < 0)