Unverified Commit c410976a authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/komeda: plane: Remove redundant zpos initialisation 



The komeda KMS driver will call drm_plane_create_zpos_property() with an
init value of the plane index.

Since the initial value wasn't carried over in the state, the driver had
to set it again in komeda_plane_reset(). However, the helpers have been
adjusted to set it properly at reset, so this is not needed anymore.

Cc: Brian Starkey <brian.starkey@arm.com>
Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Mihail Atanassov <mihail.atanassov@arm.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Acked-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220221095918.18763-10-maxime@cerno.tech
parent 8a0982b6

drivers/gpu/drm/arm/display/komeda/komeda_plane.c

+0 −2
Original line number Diff line number Diff line
@@ -135,7 +135,6 @@ static void komeda_plane_destroy(struct drm_plane *plane) 
static void komeda_plane_reset(struct drm_plane *plane)

{

	struct komeda_plane_state *state;

	struct komeda_plane *kplane = to_kplane(plane);



	if (plane->state)

		__drm_atomic_helper_plane_destroy_state(plane->state);
@@ -146,7 +145,6 @@ static void komeda_plane_reset(struct drm_plane *plane) 
	state = kzalloc(sizeof(*state), GFP_KERNEL);

	if (state) {

		__drm_atomic_helper_plane_reset(plane, &state->base);

		state->base.zpos = kplane->layer->base.id;

		state->base.color_encoding = DRM_COLOR_YCBCR_BT601;

		state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE;

	}