Commit c22659fb authored by Chaitanya Kulkarni's avatar Chaitanya Kulkarni Committed by Martin K. Petersen
Browse files

scsi: target: iscsi: Initialize arrays at declaration time 

Avoids calling memset().

Link: https://lore.kernel.org/r/20210228055645.22253-13-chaitanya.kulkarni@wdc.com


Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c4d81e7c

drivers/target/iscsi/iscsi_target_configfs.c

+1 −2
Original line number Diff line number Diff line
@@ -161,14 +161,13 @@ static struct se_tpg_np *lio_target_call_addnptotpg( 
	char *str, *str2, *ip_str, *port_str;

	struct sockaddr_storage sockaddr = { };

	int ret;

	char buf[MAX_PORTAL_LEN + 1];

	char buf[MAX_PORTAL_LEN + 1] = { };



	if (strlen(name) > MAX_PORTAL_LEN) {

		pr_err("strlen(name): %d exceeds MAX_PORTAL_LEN: %d\n",

			(int)strlen(name), MAX_PORTAL_LEN);

		return ERR_PTR(-EOVERFLOW);

	}

	memset(buf, 0, MAX_PORTAL_LEN + 1);

	snprintf(buf, MAX_PORTAL_LEN + 1, "%s", name);



	str = strstr(buf, "[");