Commit c0012a39 authored by Umang Jain's avatar Umang Jain Committed by Greg Kroah-Hartman
Browse files

vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use 



In commit 7967656f ("coding-style: Clarify the expectations around
bool") the check to dis-allow bool structure members was removed from
checkpatch.pl. It promotes bool structure members to store boolean
values. This enhances code readability.

Signed-off-by: default avatarUmang Jain <umang.jain@ideasonboard.com>
Reviewed-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://lore.kernel.org/r/20221118084244.199909-3-umang.jain@ideasonboard.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 73361173

drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c

+3 −3
Original line number Diff line number Diff line
@@ -1648,7 +1648,7 @@ int vchiq_mmal_component_init(struct vchiq_mmal_instance *instance, 
	for (idx = 0; idx < VCHIQ_MMAL_MAX_COMPONENTS; idx++) {

		if (!instance->component[idx].in_use) {

			component = &instance->component[idx];

			component->in_use = 1;

			component->in_use = true;

			break;

		}

	}
@@ -1724,7 +1724,7 @@ int vchiq_mmal_component_init(struct vchiq_mmal_instance *instance, 
	destroy_component(instance, component);

unlock:

	if (component)

		component->in_use = 0;

		component->in_use = false;

	mutex_unlock(&instance->vchiq_mutex);



	return ret;
@@ -1747,7 +1747,7 @@ int vchiq_mmal_component_finalise(struct vchiq_mmal_instance *instance, 


	ret = destroy_component(instance, component);



	component->in_use = 0;

	component->in_use = false;



	mutex_unlock(&instance->vchiq_mutex);

drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ struct vchiq_mmal_port { 
};



struct vchiq_mmal_component {

	u32 in_use:1;

	bool in_use;

	bool enabled;

	u32 handle;  /* VideoCore handle for component */

	u32 inputs;  /* Number of input ports */