Commit bd7a33bf authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Corey Minyard
Browse files

ipmi_si: Use proper ACPI macros to check error code for failures 



Instead of direct comparison, use proper ACPI macros to check error code
for failures.

While at it, drop unneeded 'else' keyword.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Message-Id: <20210402174334.13466-5-andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 96c4d0de

drivers/char/ipmi/ipmi_si_platform.c

+6 −6
Original line number Diff line number Diff line
@@ -85,19 +85,19 @@ static int acpi_gpe_irq_setup(struct si_sm_io *io) 
					  ACPI_GPE_LEVEL_TRIGGERED,

					  &ipmi_acpi_gpe,

					  io);

	if (status != AE_OK) {

	if (ACPI_FAILURE(status)) {

		dev_warn(io->dev,

			 "Unable to claim ACPI GPE %d, running polled\n",

			 io->irq);

		io->irq = 0;

		return -EINVAL;

	} else {

	}



	io->irq_cleanup = acpi_gpe_irq_cleanup;

	ipmi_irq_finish_setup(io);

	dev_info(io->dev, "Using ACPI GPE %d\n", io->irq);

	return 0;

}

}

#endif



static void ipmi_set_addr_data_and_space(struct resource *r, struct si_sm_io *io)