Commit bcf9d61a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron
Browse files

iio: accel: bmi088: Make bmi088_accel_core_remove() return void 



Up to now bmi088_accel_core_remove() returns zero unconditionally. Make
it return void instead which makes it easier to see in the callers that
there is no error to handle.

Also the return value of spi remove callbacks is ignored anyway.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarAlexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/20211013203223.2694577-4-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 9713964f

drivers/iio/accel/bmi088-accel-core.c

+1 −3
Original line number Diff line number Diff line
@@ -536,7 +536,7 @@ int bmi088_accel_core_probe(struct device *dev, struct regmap *regmap, 
EXPORT_SYMBOL_GPL(bmi088_accel_core_probe);





int bmi088_accel_core_remove(struct device *dev)

void bmi088_accel_core_remove(struct device *dev)

{

	struct iio_dev *indio_dev = dev_get_drvdata(dev);

	struct bmi088_accel_data *data = iio_priv(indio_dev);
@@ -546,8 +546,6 @@ int bmi088_accel_core_remove(struct device *dev) 
	pm_runtime_disable(dev);

	pm_runtime_set_suspended(dev);

	bmi088_accel_power_down(data);



	return 0;

}

EXPORT_SYMBOL_GPL(bmi088_accel_core_remove);

drivers/iio/accel/bmi088-accel-spi.c

+3 −1
Original line number Diff line number Diff line
@@ -58,7 +58,9 @@ static int bmi088_accel_probe(struct spi_device *spi) 


static int bmi088_accel_remove(struct spi_device *spi)

{

	return bmi088_accel_core_remove(&spi->dev);

	bmi088_accel_core_remove(&spi->dev);



	return 0;

}



static const struct spi_device_id bmi088_accel_id[] = {

drivers/iio/accel/bmi088-accel.h

+1 −1
Original line number Diff line number Diff line
@@ -13,6 +13,6 @@ extern const struct dev_pm_ops bmi088_accel_pm_ops; 


int bmi088_accel_core_probe(struct device *dev, struct regmap *regmap, int irq,

			    const char *name, bool block_supported);

int bmi088_accel_core_remove(struct device *dev);

void bmi088_accel_core_remove(struct device *dev);



#endif /* BMI088_ACCEL_H */