Commit ba3e4a2a authored by Wang Hai's avatar Wang Hai Committed by Greg Kroah-Hartman
Browse files

staging: mfd: hi6421-spmi-pmic: fix error return code in hi6421_spmi_pmic_probe() 



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 4524ac56 ("staging: mfd: add a PMIC driver for HiSilicon 6421 SPMI version")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWang Hai <wanghai38@huawei.com>
Link: https://lore.kernel.org/r/20201118103724.57451-1-wanghai38@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1f59b066

drivers/staging/hikey9xx/hi6421-spmi-pmic.c

+3 −1
Original line number Diff line number Diff line
@@ -262,8 +262,10 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev) 
	hi6421_spmi_pmic_irq_prc(pmic);



	pmic->irqs = devm_kzalloc(dev, HISI_IRQ_NUM * sizeof(int), GFP_KERNEL);

	if (!pmic->irqs)

	if (!pmic->irqs) {

		ret = -ENOMEM;

		goto irq_malloc;

	}



	pmic->domain = irq_domain_add_simple(np, HISI_IRQ_NUM, 0,

					     &hi6421_spmi_domain_ops, pmic);