Commit b933456c authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/hpfb: Initialize fb_ops to fbdev I/O-memory helpers 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-19-tzimmermann@suse.de
parent a1a1c3fa

drivers/video/fbdev/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -407,6 +407,7 @@ config FB_HP300 
	bool

	depends on (FB = y) && DIO

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_FOPS

	default y



config FB_TGA

drivers/video/fbdev/hpfb.c

+2 −0
Original line number Diff line number Diff line
@@ -186,12 +186,14 @@ static int hpfb_sync(struct fb_info *info) 


static const struct fb_ops hpfb_ops = {

	.owner		= THIS_MODULE,

	__FB_DEFAULT_IOMEM_OPS_RDWR,

	.fb_setcolreg	= hpfb_setcolreg,

	.fb_blank	= hpfb_blank,

	.fb_fillrect	= hpfb_fillrect,

	.fb_copyarea	= hpfb_copyarea,

	.fb_imageblit	= cfb_imageblit,

	.fb_sync	= hpfb_sync,

	__FB_DEFAULT_IOMEM_OPS_MMAP,

};



/* Common to all HP framebuffers */