Commit b822039b authored by Michal Simek's avatar Michal Simek Committed by Wolfram Sang
Browse files

i2c: xiic: Fix coding style issues 



Most of these stuff are reported by checkpatch.
But fixes are:
- Incorrect indetation
- Missing blank line after variable declaration
- Additional ()
- Missing spaces around +
- Missing parenthesis when if has them
- Newlines
- Remove MODULE_ALIAS - none is really using it

Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
Signed-off-by: default avatarShubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 8fa9c938

drivers/i2c/busses/i2c-xiic.c

+20 −17
Original line number Diff line number Diff line
@@ -78,7 +78,6 @@ struct xiic_i2c { 
	bool singlemaster;

};





#define XIIC_MSB_OFFSET 0

#define XIIC_REG_OFFSET (0x100 + XIIC_MSB_OFFSET)
@@ -233,18 +232,21 @@ static inline int xiic_getreg32(struct xiic_i2c *i2c, int reg) 
static inline void xiic_irq_dis(struct xiic_i2c *i2c, u32 mask)

{

	u32 ier = xiic_getreg32(i2c, XIIC_IIER_OFFSET);



	xiic_setreg32(i2c, XIIC_IIER_OFFSET, ier & ~mask);

}



static inline void xiic_irq_en(struct xiic_i2c *i2c, u32 mask)

{

	u32 ier = xiic_getreg32(i2c, XIIC_IIER_OFFSET);



	xiic_setreg32(i2c, XIIC_IIER_OFFSET, ier | mask);

}



static inline void xiic_irq_clr(struct xiic_i2c *i2c, u32 mask)

{

	u32 isr = xiic_getreg32(i2c, XIIC_IISR_OFFSET);



	xiic_setreg32(i2c, XIIC_IISR_OFFSET, isr & mask);

}
@@ -355,7 +357,8 @@ static void xiic_fill_tx_fifo(struct xiic_i2c *i2c) 


	while (len--) {

		u16 data = i2c->tx_msg->buf[i2c->tx_pos++];

		if ((xiic_tx_space(i2c) == 0) && (i2c->nmsgs == 1)) {



		if (!xiic_tx_space(i2c) && i2c->nmsgs == 1) {

			/* last message in transfer -> STOP */

			data |= XIIC_TX_DYN_STOP_MASK;

			dev_dbg(i2c->adap.dev.parent, "%s TX STOP\n", __func__);
@@ -641,6 +644,7 @@ static void xiic_start_send(struct xiic_i2c *i2c) 
static void __xiic_start_xfer(struct xiic_i2c *i2c)

{

	int fifo_space = xiic_tx_fifo_space(i2c);



	dev_dbg(i2c->adap.dev.parent, "%s entry, msg: %p, fifos space: %d\n",

		__func__, i2c->tx_msg, fifo_space);
@@ -742,7 +746,6 @@ static const struct i2c_adapter xiic_adapter = { 
	.quirks = &xiic_quirks,

};





static int xiic_i2c_probe(struct platform_device *pdev)

{

	struct xiic_i2c *i2c;
@@ -902,6 +905,7 @@ static const struct dev_pm_ops xiic_dev_pm_ops = { 
	SET_RUNTIME_PM_OPS(xiic_i2c_runtime_suspend,

			   xiic_i2c_runtime_resume, NULL)

};



static struct platform_driver xiic_i2c_driver = {

	.probe   = xiic_i2c_probe,

	.remove  = xiic_i2c_remove,
@@ -917,4 +921,3 @@ module_platform_driver(xiic_i2c_driver); 
MODULE_AUTHOR("info@mocean-labs.com");

MODULE_DESCRIPTION("Xilinx I2C bus driver");

MODULE_LICENSE("GPL v2");
 
MODULE_ALIAS("platform:"DRIVER_NAME);