Commit b639b59b authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: Remove ufshcd_lrb.sense_bufflen 

ufshcd_lrb.sense_bufflen is set but never read. Hence remove this struct
member.

Link: https://lore.kernel.org/r/20220419225811.4127248-6-bvanassche@acm.org


Tested-by: default avatarBean Huo <beanhuo@micron.com>
Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Reviewed-by: default avatarKeoseong Park <keosung.park@samsung.com>
Reviewed-by: default avatarBean Huo <beanhuo@micron.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a858af9a

drivers/scsi/ufs/ufshcd.c

+0 −3
Original line number Diff line number Diff line
@@ -2789,7 +2789,6 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) 
	lrbp = &hba->lrb[tag];

	WARN_ON(lrbp->cmd);

	lrbp->cmd = cmd;

	lrbp->sense_bufflen = UFS_SENSE_SIZE;

	lrbp->sense_buffer = cmd->sense_buffer;

	lrbp->task_tag = tag;

	lrbp->lun = ufshcd_scsi_to_upiu_lun(cmd->device->lun);
@@ -2830,7 +2829,6 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba *hba, 
		struct ufshcd_lrb *lrbp, enum dev_cmd_type cmd_type, int tag)

{

	lrbp->cmd = NULL;

	lrbp->sense_bufflen = 0;

	lrbp->sense_buffer = NULL;

	lrbp->task_tag = tag;

	lrbp->lun = 0; /* device management cmd is not specific to any LUN */
@@ -6802,7 +6800,6 @@ static int ufshcd_issue_devman_upiu_cmd(struct ufs_hba *hba, 
	lrbp = &hba->lrb[tag];

	WARN_ON(lrbp->cmd);

	lrbp->cmd = NULL;

	lrbp->sense_bufflen = 0;

	lrbp->sense_buffer = NULL;

	lrbp->task_tag = tag;

	lrbp->lun = 0;

drivers/scsi/ufs/ufshcd.h

+0 −2
Original line number Diff line number Diff line
@@ -182,7 +182,6 @@ struct ufs_pm_lvl_states { 
 * @ucd_req_dma_addr: UPIU request dma address for debug

 * @cmd: pointer to SCSI command

 * @sense_buffer: pointer to sense buffer address of the SCSI command

 * @sense_bufflen: Length of the sense buffer

 * @scsi_status: SCSI status of the command

 * @command_type: SCSI, UFS, Query.

 * @task_tag: Task tag of the command
@@ -207,7 +206,6 @@ struct ufshcd_lrb { 


	struct scsi_cmnd *cmd;

	u8 *sense_buffer;

	unsigned int sense_bufflen;

	int scsi_status;



	int command_type;