Commit b5c2e0ab authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] snd_tea575x: precedence bug in fmr2_tea575x_get_pins() 



The "|" operation has higher precedence that "?:" so this couldn't
return both flags set at once as intended.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 8510ae4e

drivers/media/radio/radio-sf16fmr2.c

+2 −2
Original line number Diff line number Diff line
@@ -74,8 +74,8 @@ static u8 fmr2_tea575x_get_pins(struct snd_tea575x *tea) 
	struct fmr2 *fmr2 = tea->private_data;

	u8 bits = inb(fmr2->io);



	return  (bits & STR_DATA) ? TEA575X_DATA : 0 |

		(bits & STR_MOST) ? TEA575X_MOST : 0;

	return  ((bits & STR_DATA) ? TEA575X_DATA : 0) |

		((bits & STR_MOST) ? TEA575X_MOST : 0);

}



static void fmr2_tea575x_set_direction(struct snd_tea575x *tea, bool output)