Commit b50df2f5 authored by Luca Ceresoli's avatar Luca Ceresoli Committed by Linus Walleij
Browse files

pinctrl: tegra: add OF node when logging OF parsing errors 



These errors are not quite clear without also logging they device tree node
being parsed, especially when the pinmux node has lots of subnodes. Adding
the node name helps a lot in finding the node that triggers the error.

Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20230926103938.334055-1-luca.ceresoli@bootlin.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 1d4b7855

drivers/pinctrl/tegra/pinctrl-tegra.c

+4 −4
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, 
		/* EINVAL=missing, which is fine since it's optional */

		if (ret != -EINVAL)

			dev_err(dev,

				"could not parse property nvidia,function\n");

				"%pOF: could not parse property nvidia,function\n", np);

		function = NULL;

	}
@@ -135,8 +135,8 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, 
				goto exit;

		/* EINVAL=missing, which is fine since it's optional */

		} else if (ret != -EINVAL) {

			dev_err(dev, "could not parse property %s\n",

				cfg_params[i].property);

			dev_err(dev, "%pOF: could not parse property %s\n",

				np, cfg_params[i].property);

		}

	}
@@ -147,7 +147,7 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, 
		reserve++;

	ret = of_property_count_strings(np, "nvidia,pins");

	if (ret < 0) {

		dev_err(dev, "could not parse property nvidia,pins\n");

		dev_err(dev, "%pOF: could not parse property nvidia,pins\n", np);

		goto exit;

	}

	reserve *= ret;