Commit b3a467d9 authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: qcom-qmp-ufs: drop unused runtime PM implementation 



Drop the unused and incomplete runtime PM implementation, which was
only used by USB PHYs before splitting the QMP driver.

Note that the runtime PM was never disabled (and state restored) on
driver unbind.

This effectively reverts commit ac0d2399 ("phy: qcom-qmp: Add
support for runtime PM").

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20220907110728.19092-8-johan+linaro@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 7936e5f3

drivers/phy/qualcomm/phy-qcom-qmp-ufs.c

+0 −38
Original line number Diff line number Diff line
@@ -53,17 +53,6 @@ 
#define USB3_MODE				BIT(0) /* enables USB3 mode */

#define DP_MODE					BIT(1) /* enables DP mode */



/* QPHY_PCS_AUTONOMOUS_MODE_CTRL register bits */

#define ARCVR_DTCT_EN				BIT(0)

#define ALFPS_DTCT_EN				BIT(1)

#define ARCVR_DTCT_EVENT_SEL			BIT(4)



/* QPHY_PCS_LFPS_RXTERM_IRQ_CLEAR register bits */

#define IRQ_CLEAR				BIT(0)



/* QPHY_PCS_LFPS_RXTERM_IRQ_STATUS register bits */

#define RCVR_DETECT				BIT(0)



/* QPHY_V3_PCS_MISC_CLAMP_ENABLE register bits */

#define CLAMP_EN				BIT(0) /* enables i/o clamp_n */
@@ -125,9 +114,6 @@ enum qphy_reg_layout { 
	QPHY_START_CTRL,

	QPHY_PCS_READY_STATUS,

	QPHY_PCS_STATUS,

	QPHY_PCS_AUTONOMOUS_MODE_CTRL,

	QPHY_PCS_LFPS_RXTERM_IRQ_CLEAR,

	QPHY_PCS_LFPS_RXTERM_IRQ_STATUS,

	QPHY_PCS_POWER_DOWN_CONTROL,

	/* PCS_MISC registers */

	QPHY_PCS_MISC_TYPEC_CTRL,
@@ -635,7 +621,6 @@ struct qmp_phy_cfg { 
 * @pcs_misc: iomapped memory space for lane's pcs_misc

 * @index: lane index

 * @qmp: QMP phy to which this lane belongs

 * @mode: current PHY mode

 */

struct qmp_phy {

	struct phy *phy;
@@ -649,7 +634,6 @@ struct qmp_phy { 
	void __iomem *pcs_misc;

	unsigned int index;

	struct qcom_qmp *qmp;

	enum phy_mode mode;

};



/**
@@ -1117,16 +1101,6 @@ static int qcom_qmp_phy_ufs_disable(struct phy *phy) 
	return qcom_qmp_phy_ufs_exit(phy);

}



static int qcom_qmp_phy_ufs_set_mode(struct phy *phy,

				 enum phy_mode mode, int submode)

{

	struct qmp_phy *qphy = phy_get_drvdata(phy);



	qphy->mode = mode;



	return 0;

}



static int qcom_qmp_phy_ufs_vreg_init(struct device *dev, const struct qmp_phy_cfg *cfg)

{

	struct qcom_qmp *qmp = dev_get_drvdata(dev);
@@ -1162,7 +1136,6 @@ static int qcom_qmp_phy_ufs_clk_init(struct device *dev, const struct qmp_phy_cf 
static const struct phy_ops qcom_qmp_ufs_ops = {

	.power_on	= qcom_qmp_phy_ufs_enable,

	.power_off	= qcom_qmp_phy_ufs_disable,

	.set_mode	= qcom_qmp_phy_ufs_set_mode,

	.owner		= THIS_MODULE,

};
@@ -1332,14 +1305,6 @@ static int qcom_qmp_phy_ufs_probe(struct platform_device *pdev) 
	if (!qmp->phys)

		return -ENOMEM;



	pm_runtime_set_active(dev);

	pm_runtime_enable(dev);

	/*

	 * Prevent runtime pm from being ON by default. Users can enable

	 * it using power/control in sysfs.

	 */

	pm_runtime_forbid(dev);



	id = 0;

	for_each_available_child_of_node(dev->of_node, child) {

		/* Create per-lane phy */
@@ -1356,13 +1321,10 @@ static int qcom_qmp_phy_ufs_probe(struct platform_device *pdev) 
	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);

	if (!IS_ERR(phy_provider))

		dev_info(dev, "Registered Qcom-QMP phy\n");

	else

		pm_runtime_disable(dev);



	return PTR_ERR_OR_ZERO(phy_provider);



err_node_put:

	pm_runtime_disable(dev);

	of_node_put(child);

	return ret;

}