Commit b1e96b50 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Vinod Koul
Browse files

dt-bindings: phy: qcom,qusb2: do not define properties in "if" block 



It is more readable to define properties in top-level "properties:" and
restrict them (if needed) per compatible in the "if" block.  Defining
properties in "if" block  does not work correctly with
additionalProperties:false:

  sc7180-trogdor-pazquel-lte-ti.dtb: phy@88e3000: 'qcom,bias-ctrl-value', 'qcom,charge-ctrl-value', 'qcom,hsdisc-trim-value',
    'qcom,imp-res-offset-value', 'qcom,preemphasis-level', 'qcom,preemphasis-width' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20221224154226.43417-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 9160fb7c

Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml

+85 −75
Original line number Diff line number Diff line
@@ -82,13 +82,6 @@ properties: 
      Phandle to TCSR syscon register region.

    $ref: /schemas/types.yaml#/definitions/phandle



if:

  properties:

    compatible:

      contains:

        const: qcom,qusb2-v2-phy

then:

  properties:

  qcom,imp-res-offset-value:

    description:

      It is a 6 bit value that specifies offset to be
@@ -169,6 +162,23 @@ required: 
  - vdda-phy-dpdm-supply

  - resets



allOf:

  - if:

      not:

        properties:

          compatible:

            contains:

              const: qcom,qusb2-v2-phy

    then:

      properties:

        qcom,imp-res-offset-value: false

        qcom,bias-ctrl-value: false

        qcom,charge-ctrl-value: false

        qcom,hstx-trim-value: false

        qcom,preemphasis-level: false

        qcom,preemphasis-width: false

        qcom,hsdisc-trim-value: false



additionalProperties: false



examples: