Commit b1d33f4b authored by Stefan Richter's avatar Stefan Richter Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (13409): firedtv: packet requeuing is likely to succeed 



Packet DMA buffers are queued either initially all at once (then, a
queueing failure will cause firedtv to release the DMA context as a
whole) or subsequently one by one as they recycled after use (then a
failure is extremely unlikely).  Therefore we can be a little less
cautious when counting at which packet buffer to set the interrupt flag.

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a8aeb783

drivers/media/dvb/firewire/firedtv-fw.c

+4 −9
Original line number Diff line number Diff line
@@ -79,19 +79,14 @@ struct firedtv_receive_context { 
static int queue_iso(struct firedtv_receive_context *ctx, int index)

{

	struct fw_iso_packet p;

	int err;



	p.payload_length = MAX_PACKET_SIZE;

	p.interrupt = !(ctx->interrupt_packet & (IRQ_INTERVAL - 1));

	p.interrupt = !(++ctx->interrupt_packet & (IRQ_INTERVAL - 1));

	p.skip = 0;

	p.header_length = ISO_HEADER_SIZE;



	err = fw_iso_context_queue(ctx->context, &p, &ctx->buffer,

	return fw_iso_context_queue(ctx->context, &p, &ctx->buffer,

				    index * MAX_PACKET_SIZE);

	if (!err)

		ctx->interrupt_packet++;



	return err;

}



static void handle_iso(struct fw_iso_context *context, u32 cycle,
@@ -150,7 +145,7 @@ static int start_iso(struct firedtv *fdtv) 
	if (err)

		goto fail_context_destroy;



	ctx->interrupt_packet = 1;

	ctx->interrupt_packet = 0;

	ctx->current_packet = 0;



	for (i = 0; i < N_PAGES; i++)