Commit afa2e976 authored by John B. Wyatt IV's avatar John B. Wyatt IV Committed by Greg Kroah-Hartman
Browse files

staging: vt6656: add error code handling to unused variable 



Add error code handling to unused 'ret' variable that was never used.
Return an error code from functions called within vnt_radio_power_on.

Issue reported by coccinelle (coccicheck).

Suggested-by: default avatarQuentin Deslandes <quentin.deslandes@itdev.co.uk>
Suggested-by: default avatarStefano Brivio <sbrivio@redhat.com>
Reviewed-by: default avatarQuentin Deslandes <quentin.deslandes@itdev.co.uk>
Signed-off-by: default avatarJohn B. Wyatt IV <jbwyatt4@gmail.com>
Reviewed-by: default avatarStefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/20200330233900.36938-1-jbwyatt4@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 69a809e1

drivers/staging/vt6656/card.c

+12 −8
Original line number Diff line number Diff line
@@ -723,9 +723,13 @@ int vnt_radio_power_on(struct vnt_private *priv) 
{

	int ret = 0;



	vnt_exit_deep_sleep(priv);

	ret = vnt_exit_deep_sleep(priv);

	if (ret)

		return ret;



	vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);

	ret = vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);

	if (ret)

		return ret;



	switch (priv->rf_type) {

	case RF_AL2230:
@@ -734,14 +738,14 @@ int vnt_radio_power_on(struct vnt_private *priv) 
	case RF_VT3226:

	case RF_VT3226D0:

	case RF_VT3342A0:

		vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,

				    (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3));

		break;

		ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,

					  (SOFTPWRCTL_SWPE2 |

					   SOFTPWRCTL_SWPE3));

		if (ret)

			return ret;

	}



	vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);



	return ret;

	return vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);

}



void vnt_set_bss_mode(struct vnt_private *priv)