Commit ae988482 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it 

The "select" kconfig keyword provides reverse dependency, however it
doesn't check that selected symbol meets its own dependencies. Usually
"select" is used for non-visible symbols, so instead of trying to keep
dependencies in sync with BNXT ethernet driver, simply "depends on" it,
like Kconfig documentation suggest.

* CONFIG_PCI is already required by BNXT
* CONFIG_NETDEVICES and CONFIG_ETHERNET are needed to chose BNXT

Link: https://lore.kernel.org/r/20210401065715.565226-2-leon@kernel.org


Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Acked-By: default avatarDevesh Sharma <devesh.sharma@broadcom.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 338a010c

drivers/infiniband/hw/bnxt_re/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -2,9 +2,7 @@ 
config INFINIBAND_BNXT_RE

	tristate "Broadcom Netxtreme HCA support"

	depends on 64BIT

	depends on ETHERNET && NETDEVICES && PCI && INET && DCB

	select NET_VENDOR_BROADCOM

	select BNXT

	depends on INET && DCB && BNXT

	help

	  This driver supports Broadcom NetXtreme-E 10/25/40/50 gigabit

	  RoCE HCAs.  To compile this driver as a module, choose M here: