Commit adb60966 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Mauro Carvalho Chehab
Browse files

[media] cx231xx: Paranoic stack memory save 



Saves 255 bytes of stack memory on cx231xx_usb_probe() by removing a char array.

Tested by compilation only.

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 22cf83fa

drivers/media/video/cx231xx/cx231xx-cards.c

+3 −14
Original line number Diff line number Diff line
@@ -1023,7 +1023,6 @@ static int cx231xx_usb_probe(struct usb_interface *interface, 
	int nr = 0, ifnum;

	int i, isoc_pipe = 0;

	char *speed;

	char descr[255] = "";

	struct usb_interface_assoc_descriptor *assoc_desc;



	udev = usb_get_dev(interface_to_usbdev(interface));
@@ -1098,20 +1097,10 @@ static int cx231xx_usb_probe(struct usb_interface *interface, 
		speed = "unknown";

	}



	if (udev->manufacturer)

		strlcpy(descr, udev->manufacturer, sizeof(descr));



	if (udev->product) {

		if (*descr)

			strlcat(descr, " ", sizeof(descr));

		strlcat(descr, udev->product, sizeof(descr));

	}

	if (*descr)

		strlcat(descr, " ", sizeof(descr));



	cx231xx_info("New device %s@ %s Mbps "

	cx231xx_info("New device %s %s @ %s Mbps "

	     "(%04x:%04x) with %d interfaces\n",

	     descr,

	     udev->manufacturer ? udev->manufacturer : "",

	     udev->product ? udev->product : "",

	     speed,

	     le16_to_cpu(udev->descriptor.idVendor),

	     le16_to_cpu(udev->descriptor.idProduct),