Commit acf99415 authored by Serge Semin's avatar Serge Semin Committed by Bjorn Helgaas
Browse files

dmaengine: dw-edma: Depend on DW_EDMA instead of selecting it 

Kconfig "select" is discouraged for visible symbols like DW_EDMA because it
makes it possible to set DW_EDMA even if DW_EDMA depends on things that are
not set (see Documentation/kbuild/kconfig-language.txt).

Convert DW_EDMA_PCIE so it depends on DW_EDMA instead of selecting it.

There will likely be several future drivers that depend on DW_EDMA, so this
uses "if DW_EDMA" to enclose them all rather than repeating "depends on
DW_EDMA" for each.

[bhelgaas: split to separate patch, commit log]
Link: https://lore.kernel.org/r/20230113171409.30470-25-Sergey.Semin@baikalelectronics.ru


Signed-off-by: default avatarSerge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarVinod Koul <vkoul@kernel.org>
parent 16f8a086

drivers/dma/dw-edma/Kconfig

+4 −1
Original line number Diff line number Diff line
@@ -9,11 +9,14 @@ config DW_EDMA 
	  Support the Synopsys DesignWare eDMA controller, normally

	  implemented on endpoints SoCs.



if DW_EDMA



config DW_EDMA_PCIE

	tristate "Synopsys DesignWare eDMA PCIe driver"

	depends on PCI && PCI_MSI

	select DW_EDMA

	help

	  Provides a glue-logic between the Synopsys DesignWare

	  eDMA controller and an endpoint PCIe device. This also serves

	  as a reference design to whom desires to use this IP.



endif # DW_EDMA