Commit ac6fdbfe authored by Ofir Bitton's avatar Ofir Bitton Committed by Oded Gabbay
Browse files

habanalabs/gaudi: support CS with no completion 



As part of the staged submission feature, we need Gaudi to support
command submissions that will never get a completion.

Signed-off-by: default avatarOfir Bitton <obitton@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 8e39e75a

drivers/misc/habanalabs/common/command_submission.c

+1 −0
Original line number Diff line number Diff line
@@ -225,6 +225,7 @@ static int cs_parser(struct hl_fpriv *hpriv, struct hl_cs_job *job) 
	parser.queue_type = job->queue_type;

	parser.is_kernel_allocated_cb = job->is_kernel_allocated_cb;

	job->patched_cb = NULL;

	parser.completion = true;



	rc = hdev->asic_funcs->cs_parser(hdev, &parser);

drivers/misc/habanalabs/common/habanalabs.h

+2 −0
Original line number Diff line number Diff line
@@ -1223,6 +1223,7 @@ struct hl_cs_job { 
 *                    MSG_PROT packets. Relevant only for GAUDI as GOYA doesn't

 *                    have streams so the engine can't be busy by another

 *                    stream.

 * @completion: true if we need completion for this CS.

 */

struct hl_cs_parser {

	struct hl_cb		*user_cb;
@@ -1237,6 +1238,7 @@ struct hl_cs_parser { 
	u8			job_id;

	u8			is_kernel_allocated_cb;

	u8			contains_dma_pkt;

	u8			completion;

};



/*

drivers/misc/habanalabs/gaudi/gaudi.c

+7 −3
Original line number Diff line number Diff line
@@ -5060,6 +5060,7 @@ static int gaudi_validate_cb(struct hl_device *hdev, 
	 * 1. A packet that will act as a completion packet

	 * 2. A packet that will generate MSI-X interrupt

	 */

	if (parser->completion)

		parser->patched_cb_size += sizeof(struct packet_msg_prot) * 2;



	return rc;
@@ -5287,8 +5288,11 @@ static int gaudi_parse_cb_mmu(struct hl_device *hdev, 
	 * 1. A packet that will act as a completion packet

	 * 2. A packet that will generate MSI interrupt

	 */

	if (parser->completion)

		parser->patched_cb_size = parser->user_cb_size +

				sizeof(struct packet_msg_prot) * 2;

	else

		parser->patched_cb_size = parser->user_cb_size;



	rc = hl_cb_create(hdev, &hdev->kernel_cb_mgr, hdev->kernel_ctx,

				parser->patched_cb_size, false, false,