Commit ac00154a authored by Vaibhav Agarwal's avatar Vaibhav Agarwal Committed by Greg Kroah-Hartman
Browse files

greybus: audio: gb_manager: Use valid argument while removing ida allocated id. 



module->id is used as an argument to ida_simple_remove(). Since module
is already dereferenced, module->id might contain invalid data. So fix
this.

Fixes: da4cc2d0b066 ("audio:gb_manager: Use proper locking around kobject_xxx")
Signed-off-by: default avatarVaibhav Agarwal <vaibhav.agarwal@linaro.org>
Reviewed-by: default avatarMark Greer <mgreer@animalcreek.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent ef62adae

drivers/staging/greybus/audio_manager.c

+1 −1
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ int gb_audio_manager_remove(int id) 
	list_del(&module->list);

	kobject_put(&module->kobj);

	up_write(&modules_rwsem);

	ida_simple_remove(&module_id, module->id);

	ida_simple_remove(&module_id, id);

	return 0;

}

EXPORT_SYMBOL_GPL(gb_audio_manager_remove);