Commit abbd669d authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: atomisp: do another round of coding style cleanup 



Run checkpatch --fix-inline again, in order to get rid
of some additional issues that got introduced (or that
checkpatch can now detect).

This should help preventing receiving random cleanups,
while keeping the code on a better shape.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 1a16d545

drivers/staging/media/atomisp/TODO

+2 −2
Original line number Diff line number Diff line
@@ -173,8 +173,8 @@ Limitations 
   device but can also be extracted from the upgrade kit if you've managed

   to lose them somehow.



2. Without a 3A libary the capture behaviour is not very good. To take a good

   picture, you need tune ISP parameters by IOCTL functions or use a 3A libary

2. Without a 3A library the capture behaviour is not very good. To take a good

   picture, you need tune ISP parameters by IOCTL functions or use a 3A library

   such as libxcam.



3. The driver is intended to drive the PCI exposed versions of the device.

drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

+0 −1
Original line number Diff line number Diff line
@@ -1321,7 +1321,6 @@ static int gc0310_probe(struct i2c_client *client) 
		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()





	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)

		return -ENOMEM;

drivers/staging/media/atomisp/i2c/ov2680.h

+2 −0
Original line number Diff line number Diff line
@@ -456,6 +456,7 @@ static struct ov2680_reg const ov2680_656x496_30fps[] = { 
	// {0x5090, 0x0c},

	{}

};



/*

* 800x600 30fps  VBlanking 1lane 10Bit (binning)

*/
@@ -500,6 +501,7 @@ static struct ov2680_reg const ov2680_720x592_30fps[] = { 
	{0x5081, 0x41},

	{}

};



/*

* 800x600 30fps  VBlanking 1lane 10Bit (binning)

*/

drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c

+2 −2
Original line number Diff line number Diff line
@@ -1087,7 +1087,7 @@ static int ov5693_s_ctrl(struct v4l2_ctrl *ctrl) 
	case V4L2_CID_VCM_SLEW:

		ret = ov5693_t_vcm_slew(&dev->sd, ctrl->val);

		break;

	case V4L2_CID_VCM_TIMEING:

	case V4L2_CID_VCM_TIMING:

		ret = ov5693_t_vcm_timing(&dev->sd, ctrl->val);

		break;

	default:
@@ -1230,7 +1230,7 @@ static const struct v4l2_ctrl_config ov5693_controls[] = { 
	},

	{

		.ops = &ctrl_ops,

		.id = V4L2_CID_VCM_TIMEING,

		.id = V4L2_CID_VCM_TIMING,

		.type = V4L2_CTRL_TYPE_INTEGER,

		.name = "vcm step time",

		.min = 0,

drivers/staging/media/atomisp/include/linux/atomisp.h

+1 −1
Original line number Diff line number Diff line
@@ -1274,7 +1274,7 @@ struct atomisp_sensor_ae_bracketing_lut { 
/* VCM slew control */

#define V4L2_CID_VCM_SLEW                  (V4L2_CID_CAMERA_LASTP1 + 11)

/* VCM step time */

#define V4L2_CID_VCM_TIMEING               (V4L2_CID_CAMERA_LASTP1 + 12)

#define V4L2_CID_VCM_TIMING                (V4L2_CID_CAMERA_LASTP1 + 12)



/* Query Focus Status */

#define V4L2_CID_FOCUS_STATUS              (V4L2_CID_CAMERA_LASTP1 + 14)