Commit ab574f6a authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Oded Gabbay
Browse files

accel/habanalabs: disable events ioctls on control device 



Because it is not used and also, for graceful reset to work
those ioctls should run on the compute device.

Signed-off-by: default avatarDafna Hirschfeld <dhirschfeld@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 2b76129c

drivers/accel/habanalabs/common/device.c

+0 −13
Original line number Diff line number Diff line
@@ -572,11 +572,6 @@ static int hl_device_release_ctrl(struct inode *inode, struct file *filp) 
	list_del(&hpriv->dev_node);

	mutex_unlock(&hdev->fpriv_ctrl_list_lock);

out:

	/* release the eventfd */

	if (hpriv->notifier_event.eventfd)

		eventfd_ctx_put(hpriv->notifier_event.eventfd);



	mutex_destroy(&hpriv->notifier_event.lock);

	put_pid(hpriv->taskpid);



	kfree(hpriv);
@@ -1995,14 +1990,6 @@ void hl_notifier_event_send_all(struct hl_device *hdev, u64 event_mask) 
		hl_notifier_event_send(&hpriv->notifier_event, event_mask);



	mutex_unlock(&hdev->fpriv_list_lock);



	/* control device */

	mutex_lock(&hdev->fpriv_ctrl_list_lock);



	list_for_each_entry(hpriv, &hdev->fpriv_ctrl_list, dev_node)

		hl_notifier_event_send(&hpriv->notifier_event, event_mask);



	mutex_unlock(&hdev->fpriv_ctrl_list_lock);

}



/*

drivers/accel/habanalabs/common/habanalabs_drv.c

+0 −1
Original line number Diff line number Diff line
@@ -296,7 +296,6 @@ int hl_device_open_ctrl(struct inode *inode, struct file *filp) 
	hpriv->hdev = hdev;

	filp->private_data = hpriv;



	mutex_init(&hpriv->notifier_event.lock);

	nonseekable_open(inode, filp);



	hpriv->taskpid = get_task_pid(current, PIDTYPE_PID);

drivers/accel/habanalabs/common/habanalabs_ioctl.c

+11 −0
Original line number Diff line number Diff line
@@ -1104,6 +1104,17 @@ int hl_info_ioctl(struct drm_device *ddev, void *data, struct drm_file *file_pri 


static int hl_info_ioctl_control(struct hl_fpriv *hpriv, void *data)

{

	struct hl_info_args *args = data;



	switch (args->op) {

	case HL_INFO_GET_EVENTS:

	case HL_INFO_UNREGISTER_EVENTFD:

	case HL_INFO_REGISTER_EVENTFD:

		return -EOPNOTSUPP;

	default:

		break;

	}



	return _hl_info_ioctl(hpriv, data, hpriv->hdev->dev_ctrl);

}