Commit aac29b04 authored by Tzung-Bi Shih's avatar Tzung-Bi Shih
Browse files

platform/chrome: cros_ec_proto: handle empty payload in getting cmd mask 



cros_ec_get_host_command_version_mask() expects to receive
sizeof(struct ec_response_get_cmd_versions) from send_command().  The
payload is valid only if the return value is positive.

Return -EPROTO if send_command() returns 0 in
cros_ec_get_host_command_version_mask().

Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220609084957.3684698-19-tzungbi@kernel.org
parent 8120feba

drivers/platform/chrome/cros_ec_proto.c

+5 −0
Original line number Diff line number Diff line
@@ -458,6 +458,11 @@ static int cros_ec_get_host_command_version_mask(struct cros_ec_device *ec_dev, 
		goto exit;

	}



	if (ret == 0) {

		ret = -EPROTO;

		goto exit;

	}



	rver = (struct ec_response_get_cmd_versions *)msg->data;

	*mask = rver->version_mask;

	ret = 0;