Commit a9623a8b authored by Tomer Tayar's avatar Tomer Tayar Committed by Oded Gabbay
Browse files

habanalabs: mark linux image as not loaded after hw_fini 



If hard reset fails after the call to hw_fini and before loading the
linux image to the device, a subsequent call to hw_fini should
communicate via COMMS (or MSG_TO_CPU regs for old FW versions).
However, the driver still tries in this case to communicate via the GIC,
and thus no hard reset is actually done.
To avoid that, the patch clears the linux_loaded flag after every call
to hw_fini.

Signed-off-by: default avatarTomer Tayar <ttayar@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 89aad770

drivers/misc/habanalabs/common/device.c

+5 −0
Original line number Diff line number Diff line
@@ -1075,9 +1075,12 @@ int hl_device_reset(struct hl_device *hdev, u32 flags) 
	hdev->asic_funcs->hw_fini(hdev, hard_reset);



	if (hard_reset) {

		hdev->fw_loader.linux_loaded = false;



		/* Release kernel context */

		if (hdev->kernel_ctx && hl_ctx_put(hdev->kernel_ctx) == 1)

			hdev->kernel_ctx = NULL;



		hl_vm_fini(hdev);

		hl_mmu_fini(hdev);

		hl_eq_reset(hdev, &hdev->event_queue);
@@ -1611,6 +1614,8 @@ void hl_device_fini(struct hl_device *hdev) 
	/* Reset the H/W. It will be in idle state after this returns */

	hdev->asic_funcs->hw_fini(hdev, true);



	hdev->fw_loader.linux_loaded = false;



	/* Release kernel context */

	if ((hdev->kernel_ctx) && (hl_ctx_put(hdev->kernel_ctx) != 1))

		dev_err(hdev->dev, "kernel ctx is still alive\n");