Commit a6dd3f26 authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman
Browse files

staging: vchiq_core: use define for message type shift 



Make it clear and use a define for shifting the message type.

Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Link: https://lore.kernel.org/r/1622735405-9980-9-git-send-email-stefan.wahren@i2se.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 525dd8a3

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

+4 −2
Original line number Diff line number Diff line
@@ -33,12 +33,14 @@ 
#define VCHIQ_MSG_REMOTE_RELEASE    13  /* -                                 */

#define VCHIQ_MSG_REMOTE_USE_ACTIVE 14  /* -                                 */



#define TYPE_SHIFT 24



#define VCHIQ_PORT_MAX                 (VCHIQ_MAX_SERVICES - 1)

#define VCHIQ_PORT_FREE                0x1000

#define VCHIQ_PORT_IS_VALID(port)      ((port) < VCHIQ_PORT_FREE)

#define VCHIQ_MAKE_MSG(type, srcport, dstport) \

	(((type) << 24) | ((srcport) << 12) | ((dstport) << 0))

#define VCHIQ_MSG_TYPE(msgid)          ((unsigned int)(msgid) >> 24)

	(((type) << TYPE_SHIFT) | ((srcport) << 12) | ((dstport) << 0))

#define VCHIQ_MSG_TYPE(msgid)          ((unsigned int)(msgid) >> TYPE_SHIFT)

#define VCHIQ_MSG_SRCPORT(msgid) \

	(unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff)

#define VCHIQ_MSG_DSTPORT(msgid) \