Commit a5f01428 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: don't restart WPS blinking unnecessarily 



Simplify one of the cases in rtw_led_control. If we're already blinking
during WPS, we don't have to restart this blinking when the caller
requests it again. We can simply return and keep on blinking.

Tested-by: default avatarMichael Straube <straube.linux@gmail.com>
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220905200146.82259-3-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d25cb838

drivers/staging/r8188eu/core/rtw_led.c

+25 −24
Original line number Diff line number Diff line
@@ -309,7 +309,9 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction) 
		}

		break;

	case LED_CTL_START_WPS: /* wait until xinpin finish */

		if (!pLed->bLedWPSBlinkInProgress) {

		if (pLed->bLedWPSBlinkInProgress)

			return;



		if (pLed->bLedNoLinkBlinkInProgress) {

			cancel_delayed_work(&pLed->blink_work);

			pLed->bLedNoLinkBlinkInProgress = false;
@@ -333,7 +335,6 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction) 
		else

			pLed->BlinkingLedState = RTW_LED_ON;

		schedule_delayed_work(&pLed->blink_work, LED_BLINK_SCAN_INTVL);

		}

		break;

	case LED_CTL_STOP_WPS:

		if (pLed->bLedNoLinkBlinkInProgress) {