Commit a357a784 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab
Browse files

saa7134: drop unnecessary list_empty 

list_for_each_safe is able to handle an empty list.
The only effect of avoiding the loop is not initializing the
index variable.
Drop list_empty tests in cases where these variables are not
used.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

<smpl>
@@
expression x,e;
iterator name list_for_each_safe;
statement S;
identifier i,j;
@@

-if (!(list_empty(x))) {
   list_for_each_safe(i,j,x) S
- }
 ... when != i
     when != j
(
  i = e;
|
? j = e;
)
</smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent a5073212

drivers/media/pci/saa7134/saa7134-core.c

+6 −8
Original line number Diff line number Diff line
@@ -359,7 +359,6 @@ void saa7134_stop_streaming(struct saa7134_dev *dev, struct saa7134_dmaqueue *q) 
	struct saa7134_buf *tmp;



	spin_lock_irqsave(&dev->slock, flags);

	if (!list_empty(&q->queue)) {

	list_for_each_safe(pos, n, &q->queue) {

		tmp = list_entry(pos, struct saa7134_buf, entry);

		vb2_buffer_done(&tmp->vb2.vb2_buf,
@@ -367,7 +366,6 @@ void saa7134_stop_streaming(struct saa7134_dev *dev, struct saa7134_dmaqueue *q) 
		list_del(pos);

		tmp = NULL;

	}

	}

	spin_unlock_irqrestore(&dev->slock, flags);

	saa7134_buffer_timeout(&q->timeout); /* also calls del_timer(&q->timeout) */

}