Commit a354e0d8 authored Mar 04, 2015 by Aya Mahfouz Committed by Greg Kroah-Hartman Mar 06, 2015

staging: lustre: llite: remove extra parentheses around right bit shift operation



Removes extra parentheses around bitwise right shift operation.
The case handled here is when the resultant value is assigned to
a variable. The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
>>
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
>>
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
>>
-c)
+c
,...);

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 159dc4bf

drivers/staging/lustre/lustre/llite/vvp_dev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -286,7 +286,7 @@ static void vvp_pgcache_id_unpack(loff_t pos, struct vvp_pgcache_id *id)

		id->vpi_index = pos & 0xffffffff;
		id->vpi_depth = (pos >> PGC_DEPTH_SHIFT) & 0xf;
		id->vpi_bucket = ((unsigned long long)pos >> PGC_OBJ_SHIFT);
		id->vpi_bucket = (unsigned long long)pos >> PGC_OBJ_SHIFT;
		}

		static loff_t vvp_pgcache_id_pack(struct vvp_pgcache_id *id)