Commit a1f85332 authored by Ofir Bitton's avatar Ofir Bitton Committed by Oded Gabbay
Browse files

habanalabs: remove access to kernel memory using debugfs 



Accessing kernel allocated memory through debugfs should not
be allowed as it introduces a security vulnerability.
We remove the option to read/write kernel memory for all asics.

Signed-off-by: default avatarOfir Bitton <obitton@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 266cdfa2

drivers/misc/habanalabs/gaudi/gaudi.c

+0 −8
Original line number Diff line number Diff line
@@ -5734,8 +5734,6 @@ static int gaudi_debugfs_read32(struct hl_device *hdev, u64 addr, u32 *val) 
		}

		if (hbm_bar_addr == U64_MAX)

			rc = -EIO;

	} else if (addr >= HOST_PHYS_BASE && !iommu_present(&pci_bus_type)) {

		*val = *(u32 *) phys_to_virt(addr - HOST_PHYS_BASE);

	} else {

		rc = -EFAULT;

	}
@@ -5781,8 +5779,6 @@ static int gaudi_debugfs_write32(struct hl_device *hdev, u64 addr, u32 val) 
		}

		if (hbm_bar_addr == U64_MAX)

			rc = -EIO;

	} else if (addr >= HOST_PHYS_BASE && !iommu_present(&pci_bus_type)) {

		*(u32 *) phys_to_virt(addr - HOST_PHYS_BASE) = val;

	} else {

		rc = -EFAULT;

	}
@@ -5832,8 +5828,6 @@ static int gaudi_debugfs_read64(struct hl_device *hdev, u64 addr, u64 *val) 
		}

		if (hbm_bar_addr == U64_MAX)

			rc = -EIO;

	} else if (addr >= HOST_PHYS_BASE && !iommu_present(&pci_bus_type)) {

		*val = *(u64 *) phys_to_virt(addr - HOST_PHYS_BASE);

	} else {

		rc = -EFAULT;

	}
@@ -5882,8 +5876,6 @@ static int gaudi_debugfs_write64(struct hl_device *hdev, u64 addr, u64 val) 
		}

		if (hbm_bar_addr == U64_MAX)

			rc = -EIO;

	} else if (addr >= HOST_PHYS_BASE && !iommu_present(&pci_bus_type)) {

		*(u64 *) phys_to_virt(addr - HOST_PHYS_BASE) = val;

	} else {

		rc = -EFAULT;

	}

drivers/misc/habanalabs/goya/goya.c

+0 −12
Original line number Diff line number Diff line
@@ -4122,9 +4122,6 @@ static int goya_debugfs_read32(struct hl_device *hdev, u64 addr, u32 *val) 
		if (ddr_bar_addr == U64_MAX)

			rc = -EIO;



	} else if (addr >= HOST_PHYS_BASE && !iommu_present(&pci_bus_type)) {

		*val = *(u32 *) phys_to_virt(addr - HOST_PHYS_BASE);



	} else {

		rc = -EFAULT;

	}
@@ -4178,9 +4175,6 @@ static int goya_debugfs_write32(struct hl_device *hdev, u64 addr, u32 val) 
		if (ddr_bar_addr == U64_MAX)

			rc = -EIO;



	} else if (addr >= HOST_PHYS_BASE && !iommu_present(&pci_bus_type)) {

		*(u32 *) phys_to_virt(addr - HOST_PHYS_BASE) = val;



	} else {

		rc = -EFAULT;

	}
@@ -4223,9 +4217,6 @@ static int goya_debugfs_read64(struct hl_device *hdev, u64 addr, u64 *val) 
		if (ddr_bar_addr == U64_MAX)

			rc = -EIO;



	} else if (addr >= HOST_PHYS_BASE && !iommu_present(&pci_bus_type)) {

		*val = *(u64 *) phys_to_virt(addr - HOST_PHYS_BASE);



	} else {

		rc = -EFAULT;

	}
@@ -4266,9 +4257,6 @@ static int goya_debugfs_write64(struct hl_device *hdev, u64 addr, u64 val) 
		if (ddr_bar_addr == U64_MAX)

			rc = -EIO;



	} else if (addr >= HOST_PHYS_BASE && !iommu_present(&pci_bus_type)) {

		*(u64 *) phys_to_virt(addr - HOST_PHYS_BASE) = val;



	} else {

		rc = -EFAULT;

	}