Unverified Commit a1c0752c authored by Wedson Almeida Filho's avatar Wedson Almeida Filho Committed by Christian Brauner
Browse files

f2fs: move f2fs_xattr_handlers and f2fs_xattr_handler_map to .rodata 



This makes it harder for accidental or malicious changes to
f2fs_xattr_handlers or f2fs_xattr_handler_map at runtime.

Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net
Signed-off-by: default avatarWedson Almeida Filho <walmeida@microsoft.com>
Link: https://lore.kernel.org/r/20230930050033.41174-11-wedsonaf@gmail.com


Reviewed-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent ce78a1ec

fs/f2fs/xattr.c

+2 −2
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ const struct xattr_handler f2fs_xattr_security_handler = { 
	.set	= f2fs_xattr_generic_set,

};



static const struct xattr_handler *f2fs_xattr_handler_map[] = {

static const struct xattr_handler * const f2fs_xattr_handler_map[] = {

	[F2FS_XATTR_INDEX_USER] = &f2fs_xattr_user_handler,

#ifdef CONFIG_F2FS_FS_POSIX_ACL

	[F2FS_XATTR_INDEX_POSIX_ACL_ACCESS] = &nop_posix_acl_access,
@@ -202,7 +202,7 @@ static const struct xattr_handler *f2fs_xattr_handler_map[] = { 
	[F2FS_XATTR_INDEX_ADVISE] = &f2fs_xattr_advise_handler,

};



const struct xattr_handler *f2fs_xattr_handlers[] = {

const struct xattr_handler * const f2fs_xattr_handlers[] = {

	&f2fs_xattr_user_handler,

	&f2fs_xattr_trusted_handler,

#ifdef CONFIG_F2FS_FS_SECURITY

fs/f2fs/xattr.h

+1 −1
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ extern const struct xattr_handler f2fs_xattr_trusted_handler; 
extern const struct xattr_handler f2fs_xattr_advise_handler;

extern const struct xattr_handler f2fs_xattr_security_handler;



extern const struct xattr_handler *f2fs_xattr_handlers[];

extern const struct xattr_handler * const f2fs_xattr_handlers[];



extern int f2fs_setxattr(struct inode *, int, const char *,

				const void *, size_t, struct page *, int);