Commit a1a553e3 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix silent memory allocation failure in lpfc_sli4_bsg_link_diag_test() 

In the unlikely case of a failure to allocate an LPFC_MBOXQ_t structure, no
return status is set, thus the routine never logs an error and returns
success to the callee.

Fix by setting a return code on failure.

Link: https://lore.kernel.org/r/20210412013127.2387-9-jsmart2021@gmail.com


Co-developed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 724f6b43

drivers/scsi/lpfc/lpfc_bsg.c

+3 −1
Original line number Diff line number Diff line
@@ -2435,8 +2435,10 @@ lpfc_sli4_bsg_link_diag_test(struct bsg_job *job) 
		goto job_error;



	pmboxq = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);

	if (!pmboxq)

	if (!pmboxq) {

		rc = -ENOMEM;

		goto link_diag_test_exit;

	}



	req_len = (sizeof(struct lpfc_mbx_set_link_diag_state) -

		   sizeof(struct lpfc_sli4_cfg_mhdr));