Unverified Commit a042184c authored Nov 03, 2020 by Zhang Qilong Committed by Mark Brown Nov 09, 2020

spi: tegra114: fix reference leak in tegra spi ops



pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in two callers(tegra_spi_setup and
tegra_spi_resume), so we should fix it.

Fixes: f333a331 ("spi/tegra114: add spi driver")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103141306.5607-1-zhangqilong3@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 3482e797

drivers/spi/spi-tegra114.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -966,6 +966,7 @@ static int tegra_spi_setup(struct spi_device *spi)

		ret = pm_runtime_get_sync(tspi->dev);
		if (ret < 0) {
		pm_runtime_put_noidle(tspi->dev);
		dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret);
		if (cdata)
		tegra_spi_cleanup(spi);
		@@ -1474,6 +1475,7 @@ static int tegra_spi_resume(struct device *dev)

		ret = pm_runtime_get_sync(dev);
		if (ret < 0) {
		pm_runtime_put_noidle(dev);
		dev_err(dev, "pm runtime failed, e = %d\n", ret);
		return ret;
		}