Commit 9fabdbe8 authored by Liu Shixin's avatar Liu Shixin Committed by Greg Kroah-Hartman
Browse files

staging: pi433: use DEFINE_SHOW_ATTRIBUTE to simplify pi433_debugfs_regs 



Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.
No functional change.

Signed-off-by: default avatarLiu Shixin <liushixin2@huawei.com>
Link: https://lore.kernel.org/r/20220922142548.3248951-1-liushixin2@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2851349a

drivers/staging/pi433/pi433_if.c

+2 −14
Original line number Diff line number Diff line
@@ -1149,19 +1149,7 @@ static int pi433_debugfs_regs_show(struct seq_file *m, void *p) 


	return ret;

}



static int pi433_debugfs_regs_open(struct inode *inode, struct file *filp)

{

	return single_open(filp, pi433_debugfs_regs_show, inode->i_private);

}



static const struct file_operations debugfs_fops = {

	.llseek =	seq_lseek,

	.open =		pi433_debugfs_regs_open,

	.owner =	THIS_MODULE,

	.read =		seq_read,

	.release =	single_release

};

DEFINE_SHOW_ATTRIBUTE(pi433_debugfs_regs);



/*-------------------------------------------------------------------------*/
@@ -1320,7 +1308,7 @@ static int pi433_probe(struct spi_device *spi) 


	entry = debugfs_create_dir(dev_name(device->dev),

				   debugfs_lookup(KBUILD_MODNAME, NULL));

	debugfs_create_file("regs", 0400, entry, device, &debugfs_fops);

	debugfs_create_file("regs", 0400, entry, device, &pi433_debugfs_regs_fops);



	return 0;