Commit 9eb95648 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Linus Walleij
Browse files

pinctrl: cirrus: madera-core: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20231009083856.222030-5-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 88b3f108

drivers/pinctrl/cirrus/pinctrl-madera-core.c

+2 −4
Original line number Diff line number Diff line
@@ -1084,19 +1084,17 @@ static int madera_pin_probe(struct platform_device *pdev) 
	return 0;

}



static int madera_pin_remove(struct platform_device *pdev)

static void madera_pin_remove(struct platform_device *pdev)

{

	struct madera_pin_private *priv = platform_get_drvdata(pdev);



	if (priv->madera->pdata.gpio_configs)

		pinctrl_unregister_mappings(priv->madera->pdata.gpio_configs);



	return 0;

}



static struct platform_driver madera_pin_driver = {

	.probe = madera_pin_probe,

	.remove = madera_pin_remove,

	.remove_new = madera_pin_remove,

	.driver = {

		.name = "madera-pinctrl",

	},