Commit 9cf2014a authored by Amol Lad's avatar Amol Lad Committed by Linus Torvalds
Browse files

[PATCH] ioremap balanced with iounmap for drivers/video/stifb 



ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: default avatarAmol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Helge Deller <deller@parisc-linux.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent e4bf051b

drivers/video/stifb.c

+3 −0
Original line number Diff line number Diff line
@@ -1291,6 +1291,7 @@ stifb_init_fb(struct sti_struct *sti, int bpp_pref) 
out_err2:

	release_mem_region(fix->smem_start, fix->smem_len);

out_err1:

	iounmap(info->screen_base);

	fb_dealloc_cmap(&info->cmap);

out_err0:

	kfree(fb);
@@ -1364,6 +1365,8 @@ stifb_cleanup(void) 
			unregister_framebuffer(sti->info);

			release_mem_region(info->fix.mmio_start, info->fix.mmio_len);

		        release_mem_region(info->fix.smem_start, info->fix.smem_len);

				if (info->screen_base)

					iounmap(info->screen_base);

		        fb_dealloc_cmap(&info->cmap);

		        kfree(info); 

		}