Commit 9bb83e8f authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Mauro Carvalho Chehab
Browse files

media: Bulk remove BUG_ON(in_interrupt()) 



None of these BUG_ON()'s is justified. BUG_ON() should only be used when
there is really no way to survive.

If at all these could be replaced by lockdep_assert_preemption_enabled() to
cover all invalid caller context and not just those covered by
in_interrupt().

But all functions which are invoked from those places contain already debug
mechanisms to catch wrong context, so having these extra checks is not
having any advantage.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent d940d2f4

drivers/media/common/saa7146/saa7146_fops.c

+0 −2
Original line number Diff line number Diff line
@@ -55,8 +55,6 @@ void saa7146_dma_free(struct saa7146_dev *dev,struct videobuf_queue *q, 
	struct videobuf_dmabuf *dma=videobuf_to_dma(&buf->vb);

	DEB_EE("dev:%p, buf:%p\n", dev, buf);



	BUG_ON(in_interrupt());



	videobuf_waiton(q, &buf->vb, 0, 0);

	videobuf_dma_unmap(q->dev, dma);

	videobuf_dma_free(dma);

drivers/media/pci/bt8xx/bttv-risc.c

+0 −1
Original line number Diff line number Diff line
@@ -572,7 +572,6 @@ bttv_dma_free(struct videobuf_queue *q,struct bttv *btv, struct bttv_buffer *buf 
{

	struct videobuf_dmabuf *dma=videobuf_to_dma(&buf->vb);



	BUG_ON(in_interrupt());

	videobuf_waiton(q, &buf->vb, 0, 0);

	videobuf_dma_unmap(q->dev, dma);

	videobuf_dma_free(dma);

drivers/media/pci/cx23885/cx23885-core.c

+0 −1
Original line number Diff line number Diff line
@@ -1322,7 +1322,6 @@ void cx23885_free_buffer(struct cx23885_dev *dev, struct cx23885_buffer *buf) 
{

	struct cx23885_riscmem *risc = &buf->risc;



	BUG_ON(in_interrupt());

	pci_free_consistent(dev->pci, risc->size, risc->cpu, risc->dma);

}

drivers/media/pci/cx25821/cx25821-core.c

+0 −1
Original line number Diff line number Diff line
@@ -1198,7 +1198,6 @@ EXPORT_SYMBOL(cx25821_risc_databuffer_audio); 


void cx25821_free_buffer(struct cx25821_dev *dev, struct cx25821_buffer *buf)

{

	BUG_ON(in_interrupt());

	if (WARN_ON(buf->risc.size == 0))

		return;

	pci_free_consistent(dev->pci,

drivers/media/platform/fsl-viu.c

+0 −2
Original line number Diff line number Diff line
@@ -381,8 +381,6 @@ static void free_buffer(struct videobuf_queue *vq, struct viu_buf *buf) 
	struct videobuf_buffer *vb = &buf->vb;

	void *vaddr = NULL;



	BUG_ON(in_interrupt());



	videobuf_waiton(vq, &buf->vb, 0, 0);



	if (vq->int_ops && vq->int_ops->vaddr)