Commit 9a032e3f authored May 19, 2021 by Rajat Asthana Committed by Greg Kroah-Hartman May 20, 2021

staging: greybus: audio: Fix sparse warning.



Sparse complains that:
   warning: restricted send_ctl_elem_iface_t degrades to integer.

I have looked at this code, and the code is fine as-is. Normally we
would frown on using the __force directive to silence Sparse warnings
but in this case it's fine. Case statements can't be made into __bitwise
types. We also can't change the type of "ctl->iface" either because that
is part of the user space API.

So just add a (__force int) to make the warning go away.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rajat Asthana <thisisrast7@gmail.com>
Link: https://lore.kernel.org/r/20210519134119.848055-1-thisisrast7@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b9f38e91

drivers/staging/greybus/audio_topology.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -676,7 +676,7 @@ static int gbaudio_tplg_create_kcontrol(struct gbaudio_module_info *gb,
		struct gbaudio_ctl_pvt *ctldata;

		switch (ctl->iface) {
		case SNDRV_CTL_ELEM_IFACE_MIXER:
		case (__force int)SNDRV_CTL_ELEM_IFACE_MIXER:
		switch (ctl->info.type) {
		case GB_AUDIO_CTL_ELEM_TYPE_ENUMERATED:
		ret = gbaudio_tplg_create_enum_kctl(gb, kctl, ctl);
		@@ -903,7 +903,7 @@ static int gbaudio_tplg_create_wcontrol(struct gbaudio_module_info *gb,
		int ret;

		switch (ctl->iface) {
		case SNDRV_CTL_ELEM_IFACE_MIXER:
		case (__force int)SNDRV_CTL_ELEM_IFACE_MIXER:
		switch (ctl->info.type) {
		case GB_AUDIO_CTL_ELEM_TYPE_ENUMERATED:
		ret = gbaudio_tplg_create_enum_ctl(gb, kctl, ctl);